fix: expired X509 certificates should be ignored for JWT usage #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An expired X509 is ignored with this fix and therefore internally not used anymore. The expired certificate won't appear in /token_key, /token_keys anymore and private_key_jwt is not done with x5t, that the X509 as trust anchor is not possible anymore. The behavior is not really changed with this PR, but no exception should be thrown in runtime. Before this PR, an Exception and with that HTTP 5xx was thrown
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185706694 The labels on this github issue will be updated when the story is started. |
strehle
requested review from
Tallicia,
tack-sap,
torsten-sap,
adrianhoelzl-sap and
a team
tack-sap
approved these changes
Jul 27, 2023
strehle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An expired X509 is ignored with this fix and therefore internally not used anymore. The expired certificate won't appear in /token_key, /token_keys anymore and private_key_jwt is not done with x5t, that the X509 as trust anchor is not possible anymore.
The behavior is not really changed with this PR, but no exception should be thrown in runtime. Before this PR, an Exception and with that HTTP 5xx was thrown