Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonar fix #2526

Merged
merged 3 commits into from
Oct 20, 2023
Merged

sonar fix #2526

merged 3 commits into from
Oct 20, 2023

Conversation

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186197642

The labels on this github issue will be updated when the story is started.

@strehle strehle changed the title sonar fix: remove not needed code sonar fix Oct 6, 2023
@strehle strehle force-pushed the sonar/removeNotNeededFileConfig branch from 84f1743 to 3f6bfd8 Compare October 6, 2023 07:28
Copy link
Contributor

@hsinn0 hsinn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that this PR contains some reformatting and added tests?

@strehle
Copy link
Member Author

strehle commented Oct 19, 2023

yes the reformatting's are from IntelliJ sonar plugin as well as the others.

The 2 sonar fixing PRs were mainly to get @klaus-sap onboarded with some small refactoring's, simply to show him the steps "how we work in UAA"

@strehle strehle added this to the 76.24.0 milestone Oct 19, 2023
@strehle strehle merged commit 92f90b2 into develop Oct 20, 2023
20 checks passed
@strehle strehle deleted the sonar/removeNotNeededFileConfig branch October 20, 2023 08:16
@cf-gitbot cf-gitbot added delivered accepted Accepted the issue and removed delivered labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted the issue
Projects
Development

Successfully merging this pull request may close these issues.

3 participants