Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes from non OIDC standard tests #2625

Closed
wants to merge 1 commit into from
Closed

fixes from non OIDC standard tests #2625

wants to merge 1 commit into from

Conversation

strehle
Copy link
Member

@strehle strehle commented Nov 28, 2023 •
edited
Loading

  • main issue. was: audience is empty in same cases
  • tests corrected, there where HS256 was used to create RS256 signature (new library checks it)
  • HMAC key length corrected (new library checks it)

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186571078

The labels on this github issue will be updated when the story is started.

@strehle
fixes from non OIDC standard tests
f76d255 
main issue. audience is empty in same cases
tests correct where HS256 can be used to create RS256 signature
HMAC key length corrected
@strehle
Copy link
Member Author

strehle commented Nov 28, 2023

sonar
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2625

@strehle strehle requested a review from a team November 28, 2023 20:55
@strehle
Copy link
Member Author

strehle commented Dec 1, 2023

close this PR, because it was mainly to discuss the incompatibilities with new nimbus-jose-jwt. To make it clear. The problems are in UAA, because UAA was/is not compatible to RFCs according to JWT processing and headers. Nevertheless, we cannot break existing customers, therefore for all issues, I created exceptions in #2624

No need to keep
#2625

@strehle strehle closed this Dec 1, 2023
@strehle strehle deleted the fix/tokenNonStandard branch May 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strehle @cf-gitbot