fix: replace regex usage with simple search #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor use of regex to create a count statement Issue found by Sonar
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187543294 The labels on this github issue will be updated when the story is started. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
server/src/main/java/org/cloudfoundry/identity/uaa/resources/jdbc/JdbcPagingList.java
Dismissed
Show resolved
Hide resolved
coolgang123
reviewed
Aug 1, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/resources/jdbc/JdbcPagingList.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/cloudfoundry/identity/uaa/resources/jdbc/JdbcPagingListTests.java
Show resolved
Hide resolved
coolgang123
added a commit
to Identity-and-Credentials/community
that referenced
this pull request
Aug 1, 2024
Credential Management (Credhub) and Identity and Auth (UAA) contributions Reviews: cloudfoundry/uaa#2980 cloudfoundry/uaa#2866 cloudfoundry/uaa#2937 cloudfoundry/credhub#751 Code Contributions: cloudfoundry/credhub#757 cloudfoundry/credhub#743 cloudfoundry/uaa-release#906 cloudfoundry/uaa#2915
hsinn0
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor use of regex to create a count statement
Issue found by Sonar