-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SAML 2024.05.30 - Not to merge but just for SAML feature branch testing #2908
Draft
Tallicia
wants to merge
142
commits into
develop
Choose a base branch
from
new-saml-0530
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23,243
−18,118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tallicia
added
in progress
DO NOT MERGE
Internal Test or WIP, please DO NOT MERGE
labels
May 30, 2024
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187710947 The labels on this github issue will be updated when the story is started. |
Tallicia
changed the title
New saml 0530
New SAML 2024.05.30 - Not to merge but just for SAML feature branch testing
May 30, 2024
...ava/org/cloudfoundry/identity/uaa/provider/saml/SamlLegacyAliasResponseForwardingFilter.java
Fixed
Show fixed
Hide fixed
duanemay
force-pushed
the
new-saml-0530
branch
5 times, most recently
from
June 14, 2024 22:11
65b0d64
to
e67a40a
Compare
duanemay
force-pushed
the
new-saml-0530
branch
9 times, most recently
from
June 24, 2024 15:54
a761b67
to
7de27a1
Compare
duanemay
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
July 5, 2024 22:17
0d3a595
to
f199f50
Compare
peterhaochen47
force-pushed
the
new-saml-0530
branch
from
July 9, 2024 01:32
46248b9
to
290f89c
Compare
duanemay
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
July 9, 2024 18:49
46248b9
to
b6cb65b
Compare
peterhaochen47
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
July 10, 2024 17:04
a97457f
to
745fff3
Compare
Guava Cache recommends moving to Caffeine Mostly a drop in replacement Although the refreshAfterWrite works a little different Signed-off-by: Duane May <duane.may@broadcom.com>
The mechanism to achieve this in the old SAML library is no longer there. Added this in to the SamlLoginAuthenticationFailureHandler. Left the logger name as SamlResponseLoggerBinding for backward compatibility, for jobs looking for the messages. [TPCF-25429] Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
maintains existing functionality Signed-off-by: Duane May <duane.may@broadcom.com>
SamlLoginIT.springSamlEndpointsWithEmptyContext - functionality changed redirects ZoneAwareKeyManagerTest - was 0 coverage, all calls are proxied to SamlKeyManager in the ThreadLocal managed by IdentityZoneHolder. Signed-off-by: Duane May <duane.may@broadcom.com>
Replace the //NOSONAR comment with a error specific SuppressWarnings annotation
duanemay
force-pushed
the
new-saml-0530
branch
from
August 23, 2024 22:57
c0bfaea
to
dbbd346
Compare
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
- Remove the existing code to store registrationId on request in the relaystate, it is stored with the request. - Also enable IDP initiated login, we don't get the registrationId in this case Signed-off-by: Duane May <duane.may@broadcom.com>
- Uses assertj and awaitility - Rename methods to include assert where applicable - Tests should include assertions java:S2699 Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the other feature branch #2862 for new SAML library replacement effort.