Identity provider key caching behavior configurable #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: In UAA 74.5.x the JWKS is not cached. With newer UAAs there is a cache which is hard coded to 10 min. If you have a fast rotation key, then this could be a problem. Solution: deactivate the cache for such IdPs with cacheJwks=false options
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187751159 The labels on this github issue will be updated when the story is started. |
|
Alternative to #2915 |
strehle
commented
Jun 6, 2024
.../org/cloudfoundry/identity/uaa/provider/AbstractExternalOAuthIdentityProviderDefinition.java
Show resolved
Hide resolved
- the relationship with tokenKeyUrl/discovery url already explained in constraints section, so no need to repeat - add some guidance to help user decide which value to pick - update config.tokenKeyUrl doc to help user understand that the token key and the JWKS are the same concept.
|
Thanks! LGTM. I pushed a commit to edit the docs. Please review. |
peterhaochen47
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: In UAA 74.5.x the JWKS is not cached. With newer UAAs there is a cache which is hard coded to 10 min.
If you have a fast rotation key, then this could be a problem.
Solution: deactivate the cache for such IdPs with cacheJwks=false options