-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Slate, and have successful platform doc builds… #3081
base: develop
Are you sure you want to change the base?
Conversation
on both Mac and Linux using Ruby 3.3.5 Step 1 - Upgrade dependencies
|
hI @fhanik ! back in UAA ? Your Ruby version is 3.0.7, but your Gemfile specified >= 3.3 FYI @peterhaochen47 / @hsinn0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without mini_racer I see error
bundler: failed to load command: middleman (/usr/local/bundle/bin/middleman)
/usr/local/bundle/gems/execjs-2.9.1/lib/execjs/runtimes.rb:68:in autodetect': Could not find a JavaScript runtime. See https://github.com/rails/execjs for a list of available runtimes. (ExecJS::RuntimeUnavailable) from /usr/local/bundle/gems/execjs-2.9.1/lib/execjs.rb:5:in
module:ExecJS'
@@ -1,15 +1,17 @@ | |||
ruby '>= 3.0' | |||
ruby '>= 3.3' | |||
source 'https://rubygems.org' | |||
|
|||
gem 'bundler', '~> 2.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gem 'bundler', '~> 2.2' | |
gem 'bundler', '~> 2.5' |
gem 'mini_racer', '~> 0.4.0', :platform => :ruby | ||
gem 'opal' | ||
gem 'opal-sprockets' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gem 'mini_racer', '~> 0.16.0', :platform => :ruby |
redcarpet (~> 3.6.0) | ||
rouge (~> 3.21) | ||
sass | ||
webrick | ||
|
||
RUBY VERSION | ||
ruby 3.0 | ||
ruby 3.3.5 | ||
|
||
BUNDLED WITH | ||
2.2.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.2.22 | |
2.5.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEPENDENCIES
bundler (~> 2.5)
docker images was updated, e.g. you can test with docker run --privileged --tty --interactive --shm-size=1 -v.:/root/uaa cfidentity/uaa-generate-docs /root/uaa/scripts/generate-docs.sh |
Awesome. I suspect this is the build image too. I will resolve it. Am I back…not quite yet, but it may be a possibility in the future. @strehle |
The docker images update broke a main pipeline job https://bosh.ci.cloudfoundry.org/teams/uaa/pipelines/uaa-acceptance-gcp/jobs/test-generate-api-docs/builds/316. As I do not have resource to put an effort on resolving it at the moment, I might have to revert the docker images update to make the pipeline green. Will see. |
I realize that the main pipeline job failure is likely to be resolved when additional changes for this PR are made. So I will wait for the changes in this PR for now. |
Since there was a The dockerfile (can you point me to it so I can send a PR?) would need to include
Now |
https://github.com/cloudfoundry/uaa-ci/blob/main/concourse/dockerfiles/uaa-generate-docs/Dockerfile |
I was working on the uaa-ci patch, but lost access while doing so. I no longer can see the repository here is the patch for the Dockerfile
add those, and we should be green on |
Can you @fhanik please sign CLA - see error . I know you was an approver for UAA already, but maybe you have to re-assign (because of changes) but we must only accept PR with a green CLA... https://tenor.com/b1jfv.gif |
I like more the OS dependent approach because then we dont have to maintain broker URLs, so we have node installation in uaa-singular and here we do:
On my machine I use and like nvm but in a docker we dont need the flexiblity of different node versions |
I signed one, but it’s probably sitting in an approval queue at Broadcom. I’ll see if I can track it down |
cool, thanks. You may have seen, that voter for docs generation now is green. .e.g. https://github.com/cloudfoundry/uaa/actions/runs/11281815112/job/31408214542?pr=3081 |
… on both Mac and Linux using Ruby 3.3.5
Step 1 - Upgrade dependencies of Slate ruby gems
Note: May require pipeline modifications to include Ruby 3.3.x