Community ignore ui on 17.3.31 #538
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idanmo
suggested changes
Apr 6, 2017
| ctx.download_resource( | ||
| join('components', 'utils.py'), | ||
| join(dirname(__file__), 'utils.py')) | ||
| join('components', 'utils.py'), |
Contributor
There was a problem hiding this comment.
Why did you change the indentation?
components/stage/scripts/create.py
Outdated
|
|
||
| nodejs_source_url = ctx_properties['nodejs_tar_source_url'] | ||
| stage_source_url = ctx_properties['stage_tar_source_url'] | ||
| print "stage_source_url={0}".format(stage_source_url) |
components/stage/scripts/create.py
Outdated
| nodejs_source_url = ctx_properties['nodejs_tar_source_url'] | ||
| stage_source_url = ctx_properties['stage_tar_source_url'] | ||
| print "stage_source_url={0}".format(stage_source_url) | ||
| ctx.instance.runtime_properties['ignore_ui'] = 'False' |
Contributor
There was a problem hiding this comment.
Perhaps call the runtime property: "skip_stage_installation" and set it to 'true'
components/stage/scripts/create.py
Outdated
| if not stage: | ||
| ctx.instance.runtime_properties['ignore_ui'] = 'True' | ||
| print "***ignore ui***" | ||
| ignore_ui = ctx.instance.runtime_properties['ignore_ui'] |
components/stage/scripts/create.py
Outdated
| ignore_ui = ctx.instance.runtime_properties['ignore_ui'] | ||
| print ctx.instance.runtime_properties['ignore_ui'].__class__ | ||
| print "ignore_ui={0}".format(ignore_ui) | ||
| if ignore_ui != 'True': |
Contributor
There was a problem hiding this comment.
Maybe in order not to get all the script indented just do something like:
if skip_stage_installation:
return
| ctx.download_resource( | ||
| join('components', 'utils.py'), | ||
| join(dirname(__file__), 'utils.py')) | ||
| join('components', 'utils.py'), |
components/stage/scripts/start.py
Outdated
| utils.start_service(STAGE_SERVICE_NAME) | ||
| ignore_ui = ctx.instance.runtime_properties['ignore_ui'] | ||
| print "ignore_ui={0}".format(ignore_ui) | ||
| if ignore_ui != 'True': |
Contributor
There was a problem hiding this comment.
skip_stage_installation = 'skip_stage_installation' in ctx.instance.runtime_properties
if skip_stage_installation:
return
components/utils.py
Outdated
|
|
||
| def download_cloudify_resource(url, service_name, destination=None): | ||
| def download_cloudify_resource( | ||
| url, service_name, destination=None, avoid_failure=False): |
Contributor
There was a problem hiding this comment.
avoid_failure -> raise_error_on_failure=True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.