update artifactory store to allow anonymous access

[mcalhoun]

what

• Added support for anonymous access to Artifactory repositories
• Added conditional logic to only set access token if it's not "anonymous"
• Updated documentation to explain anonymous access functionality

why

• Enables users to access public Artifactory repositories without authentication
• Provides flexibility for repositories that allow anonymous access
• Simplifies configuration for public repository access

references

• Related to Artifactory anonymous access documentation: https://jfrog.com/help/r/jfrog-platform-administration-documentation/permissions

Summary by CodeRabbit

• New Features
  • Enhanced authentication for Artifactory: The system now supports anonymous access, enabling more flexible repository connections.
• Documentation
  • Updated configuration guidance to include the new anonymous access option in the project documentation, with emphasis on security considerations for token management.

[mcalhoun]

• try fixing windows performance on gha #1014
• update artifactory store to allow anonymous access #1011 👈 (View in Graphite)
• update aws param store store to use getKey #1009 : 1 other dependent PR (#1010 )
• add redis store #1008
• deprecate in memory store #1007
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the logic for handling the access token within the Artifactory store setup and updates the documentation accordingly. A conditional check is added to ensure that if the access token is set to "anonymous", it is not applied, altering the authentication behavior. The documentation reflects that the access token can now be explicitly defined as "anonymous" in the configuration, expanding the available authentication options.

Changes

Files	Summary
pkg/store/artifactory_store.go	Added a conditional check in NewArtifactoryStore to skip setting the access token if it equals "anonymous".
website/docs/core-concepts/projects/configuration/stores.mdx	Updated documentation to include a new configuration option allowing the access token to be "anonymous".

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant NewArtifactoryStore
    participant ArtifactoryStore

    Client->>NewArtifactoryStore: Call with access token
    NewArtifactoryStore->>NewArtifactoryStore: Check if token equals "anonymous"
    alt Token is "anonymous"
        NewArtifactoryStore-->>ArtifactoryStore: Proceed without setting token
    else Token is not "anonymous"
        NewArtifactoryStore-->>ArtifactoryStore: Set token with provided value
    end

Loading

Possibly related PRs

• add artifactory store #921: This PR involved modifications to the ArtifactoryStore functionality, influencing the handling of access tokens similar to the changes introduced here.

Suggested labels

minor

Suggested reviewers

• osterman

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or @auto-summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @auto-title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

website/docs/core-concepts/projects/configuration/stores.mdx (1)

89-89: Enhance Grammatical Clarity in Security Note
The static analysis tool suggested adding the article “the” before the [!env] function for better clarity. Consider updating the line to:

... In such cases, use the [!env](/core-concepts/stacks/yaml-functions/env) function to reference tokens securely.
This minor change will improve the readability without altering the meaning.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~89-~89: You might be missing the article “the” here.
Context: ...erent access tokens. In such cases, use [!env](/core-concepts/stacks/yaml-funct...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61b02f7 and 2ac71c1.

📒 Files selected for processing (2)

• pkg/store/artifactory_store.go (1 hunks)
• website/docs/core-concepts/projects/configuration/stores.mdx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/store/artifactory_store.go

🧰 Additional context used

🪛 LanguageTool

website/docs/core-concepts/projects/configuration/stores.mdx

[uncategorized] ~89-~89: You might be missing the article “the” here.
Context: ...erent access tokens. In such cases, use [!env](/core-concepts/stacks/yaml-funct...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Build (windows-latest, windows)
• GitHub Check: Summary

🔇 Additional comments (1)

website/docs/core-concepts/projects/configuration/stores.mdx (1)

86-87: Clarify Anonymous Access Documentation
The newly added lines clearly explain that users can specify the access token as anonymous to use the anonymous user for accessing Artifactory repositories. This directly supports the PR objective of enabling anonymous access. Please ensure that this documentation remains in sync with the corresponding conditional logic in the Artifactory store implementation.