Fix docker:login (#43)

cloudposse · Feb 22, 2018 · 95080d4 · 95080d4
1 parent 5da76e4
commit 95080d4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/docker/Makefile.hub b/modules/docker/Makefile.hub
@@ -2,8 +2,8 @@
 ## Use DOCKER_HUB_USERNAME and DOCKER_HUB_PASSWORD env variables to pass credentials
 ## Login into docker hub
 docker\:login: $(DOCKER)
-	@if [ -n "$DOCKER" ] && [ -n "$DOCKER_HUB_USERNAME" ] && [ -n "$DOCKER_HUB_PASSWORD" ]; then\
-      $(DOCKER) login --username="$DOCKER_HUB_USERNAME" --password="$DOCKER_HUB_PASSWORD";\
+	@if [ -n "$(DOCKER_HUB_USERNAME)" ] && [ -n "$(DOCKER_HUB_PASSWORD)" ]; then \
+      $(DOCKER) login --username="$(DOCKER_HUB_USERNAME)" --password="$(DOCKER_HUB_PASSWORD)"; \
 	else \
 	  echo "Skipping docker:login. Docker credentials (DOCKER_HUB_USERNAME or DOCKER_HUB_PASSWORD) are not set"; \
 	fi;