Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle spaces in path to Docker command #357

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Handle spaces in path to Docker command #357

merged 3 commits into from
Aug 15, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Aug 13, 2023

what

  • Handle the case where the path to the docker command has a space in it
  • Update dependencies
    • Alpine 3.17 -> 3.18
    • Go 1.20.4 -> 1.20.7
    • tflint AWS ruleset 0.23.0 -> 0.26.0
    • Python packages:
      • cryptography 41.0.2 -> 41.0.3
      • awscli 1.29.9 -> 1.29.25
      • boto3 1.28.9 -> 1.28.25
      • PyGithub 1.59 -> 1.59.1
    • lint.yml workflow:
      • cloudposse/build-harness 1.8.0 -> latest
      • actions/checkout v2 -> v3
      • github/super-linter/slim v4 -> v5

why

  • On macOS, some standard directories (e.g. "Application Support") have spaces in them
  • Keep current with security patches and bug fixes

references

Note that make, and therefore build-harness, does not generally support spaces in path names. In particular, build-harness will not be extended to support spaces in the path to the build-harness installation or the current working directory.

@Nuru Nuru requested a review from a team as a code owner August 13, 2023 05:47
@Nuru Nuru added the bugfix Change that restores intended behavior label Aug 13, 2023
@Nuru Nuru requested a review from a team as a code owner August 13, 2023 21:44
@Nuru Nuru requested review from Gowiem and korenyoni August 13, 2023 21:44
@Nuru Nuru added the minor New features that do not break anything label Aug 13, 2023
@Nuru Nuru enabled auto-merge (squash) August 13, 2023 22:06
@Nuru Nuru merged commit 777ad50 into master Aug 15, 2023
7 checks passed
@Nuru Nuru deleted the docker-path-spaces branch August 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior minor New features that do not break anything modules/docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path with spaces brakes for Docker
2 participants