Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about Gnu make version #366

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Remove warning about Gnu make version #366

merged 1 commit into from
Jan 12, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jan 12, 2024

what

why

  • The warning was unnecessary, misleading, and overly specific
    • The warning checked for "GNU Make 4.4". This of course will break when version 4.5 comes out. Furthermore, Ubuntu 20.4 LTS currently has GNU Make 4.2, which also triggers the warnings
    • The issues with building on macOS that were purported to be fixed by using GNU Make have not been clearly connected to the make version. I strongly suspect any issues with builds on Mac to be related to such things as macOS shipping with the ancient bash version 3.2.57, which is missing important features available in the current bash v5, or other aspects of macOS deviations from POSIX. These should be addressed by fixing the broken build recipes, not by requiring action on the part of the user (unless action is required, like installing jq, in which case this should cause an explicit and specific error message to be generated.

@Nuru Nuru requested a review from a team as a code owner January 12, 2024 04:06
@Nuru Nuru enabled auto-merge (squash) January 12, 2024 04:06
@Nuru Nuru merged commit 284d24e into master Jan 12, 2024
8 checks passed
@Nuru Nuru deleted the revert-warning branch January 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants