Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify gomplate path in readme/Makefile #373

Closed
wants to merge 2 commits into from

Conversation

joe-niland
Copy link
Member

what

  • add vendored gomplate path in readme/Makefile
  • I understand this might be a naive solution - so I'd appreciate knowing why it wouldn't work, if that's the case. On my machine the darwin_amd64 binary is retrieved when installing via make readme/deps.

why

  • make readme/build requires external gomplate dependency, otherwise it errors

references

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR! If you haven't already joined our slack community, then we invite you to do so.

We receive an overwhelming number of contributions. By joining our slack, we'll be able to review your PR faster.

Slack Community

@joe-niland joe-niland requested review from Nuru and removed request for goruha and aknysh January 31, 2024 22:18
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-niland Thank you for this PR. I don't think this is the approach we want to take, but we will take it from here. Meanwhile, if you just rm -rf ./build-harness/vendor/ or make clean to get rid of the offending binaries, and they will be automatically re-installed for the current OS and architecture.

@osterman
Copy link
Member

osterman commented Feb 1, 2024

@joe-niland since gomplate is only one tool solved by this PR, but not the only tool affected, @Nuru wants to organize the binaries by architecture. I think he'll fix in this in a separate PR.

@joe-niland
Copy link
Member Author

@osterman thanks for the explanation

@Nuru ok, sounds good, thanks!

Closing

@joe-niland joe-niland closed this Feb 2, 2024
@joe-niland joe-niland deleted the fix/make-readme-gomplate branch February 2, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants