Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make/readme when github_repo has quotes #376

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Fix make/readme when github_repo has quotes #376

merged 4 commits into from
Feb 3, 2024

Conversation

osterman
Copy link
Member

@osterman osterman commented Feb 2, 2024

what

  • Use tr to delete quote characters

why

  • repos will never have special shell characters in their name
  • it breaks readme generation due to spurious quotes

references

@osterman osterman requested review from a team as code owners February 2, 2024 15:53
osterman
osterman commented Feb 2, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@osterman osterman merged commit de7b11d into master Feb 3, 2024
12 checks passed
@osterman osterman deleted the fix-make-readme branch February 3, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode was automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@osterman osterman

Labels
modules/readme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @Nuru