Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default var.domains to {} #17

Merged
merged 2 commits into from
Nov 25, 2023
Merged

default var.domains to {} #17

merged 2 commits into from
Nov 25, 2023

Conversation

kevcube
Copy link
Contributor

@kevcube kevcube commented Nov 24, 2023

what

  • if not specified, terraform errors trying to iterate over null

why

  • iterating with this module and wanted to use blank config, terraform errored.

references

@kevcube
default domains to {}
0ea6987 
null fails if not specified
@kevcube kevcube requested review from a team as code owners November 24, 2023 16:49
@kevcube kevcube requested review from Gowiem and nitrocode November 24, 2023 16:49
@Gowiem
Copy link
Member

Gowiem commented Nov 25, 2023

/terratest

@Gowiem Gowiem added the patch A minor, backward compatible change label Nov 25, 2023
@Gowiem
Copy link
Member

Gowiem commented Nov 25, 2023

/terratest

@Gowiem Gowiem merged commit ddd84ef into main Nov 25, 2023
16 checks passed
@Gowiem Gowiem deleted the kevcube-patch-1 branch November 25, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevcube @Gowiem