Added the option to use access tokens

[boris-dyga-SM]

That feature allows to access private GitHub repos, where custom conformance packs could be stored

what

• updates to the conformance_pack submodule
• added the acess_token variable (defaults to empty string)
• when provided its value is implemented in the conformance pack URL allowing to access private GitHub repos

why

• sometimes customized conformance packs are stored in repos with restricted access

references

[aknysh]

please see comments

also, please run the following commands and commit the changes:

make init
make github/init
make readme

thank you

[boris-dyga-SM]

When used as a submodule with Atmos it's more convenient to have it that way

…

On Thu, Jan 18, 2024, 06:20 Andriy Knysh ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In modules/conformance-pack/main.tf <#80 (comment)> : > @@ -13,5 +13,13 @@ resource "aws_config_conformance_pack" "default" { } data "http" "conformance_pack" { - url = var.conformance_pack + /* + To access a public GitHub repo the following URL is used: + https://raw.githubusercontent.com/<owner>/<repo>/<branch>/<path_to_file> + + To access a private GitHub repo an access token with appropriate permissions should be generated first and then provided in the url: + ***@***.***/<owner>/<repo>/<branch>/<path_to_file> + */ + + url = var.access_token == "" ? var.conformance_pack : "${split("://", var.conformance_pack)[0]}://${var.access_token}@${split("://", var.conformance_pack)[1]}" @boris-dyga-SM <https://github.com/boris-dyga-SM> why do we need to parse var.conformance_pack to get the parts, and to have a separate access_token variable, if the user can just provide the private repo URL in the conformance_pack conformance_pack = ***@***.***/<owner>/<repo>/<branch>/<path_to_file> Just wondering if there is any advantage of using the 2 variables instead of one? — Reply to this email directly, view it on GitHub <#80 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5RRIOJXP57D37Q5BSXFXVTYPCPIDAVCNFSM6AAAAABB6EUTECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRYG42TGNRYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[aknysh]

@boris-dyga-SM

please run the following commands and commit the changes:

make init
make github/init
make readme

[boris-dyga-SM]

@aknysh, I've run the commands and committed the changes

[aknysh]

@boris-dyga-SM thank you.

I have to ask you to address this issue as well:

Warning: [tflint] reported by reviewdog 🐶
  Missing version constraint for provider "http" in `required_providers`
  
  Raw Output:
  main.tf:15:1: warning: Missing version constraint for provider "http" in `required_providers` ()

https://github.com/cloudposse/terraform-aws-config/actions/runs/7581885659/job/20664544050?pr=80

Thank you

[aknysh]

@boris-dyga-SM thank you very much again.
Please adress the last comments, and after that please run again

make init
make github/init
make readme

[aknysh]

please see comments

[boris-dyga-SM]

@aknysh thanks for the rapid reviews. Fixed the version as well as the tflint error (had to add the versions.tf to the submodule)

[aknysh]

/terratest

[aknysh]

thanks @boris-dyga-SM