-
-
Notifications
You must be signed in to change notification settings - Fork 56
Add support for organization aggregator #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for organization aggregator #85
Conversation
c11c769
to
94c714b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IslamHeggy thanks for the PR
Please address the error
[tflint] reported by reviewdog 🐶
data "aws_iam_policy_document" "config_organization_aggregator_policy" is declared but not used
and run the following commands and commit the changes
make init
make github/init
make readme
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
I addressed all your comments in my recent commit, please let me know if anything else is needed here @aknysh |
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@IslamHeggy sorry, please run again
|
That's okay, I updated the documentation @aknysh |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @IslamHeggy
what
why
references
I used organization aggregation argument of the aws_config_configuration_aggregator provider to add the functionality.
I checked this stale PR and decided to reinvent the wheel as it has been a while since it was opened