Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use vpc tags to get vpc id #219

Closed
wants to merge 6 commits into from
Closed

feat: use vpc tags to get vpc id #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be787b6
fix: set default for vpc_id
nitrocode Jan 10, 2025
2070fbf
feat: add vpc_tags
nitrocode Jan 10, 2025
40133b9
feat: use vpc_tags
nitrocode Jan 10, 2025
a5bcf4f
feat: use data source
nitrocode Jan 10, 2025
57ad449
fix: reorder
nitrocode Jan 10, 2025
56cbf67
fix: rm comment
nitrocode Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ locals {
# The RFC 6052 "well known" NAT64 CIDR
nat64_cidr = "64:ff9b::/96"

# In case we later decide to compute it
vpc_id = var.vpc_id
vpc_id = one(data.aws_vpc.default[*].id)

#####################################################################
## Determine the set of availability zones in which to deploy subnets
Expand Down Expand Up @@ -271,7 +270,9 @@ data "aws_availability_zones" "default" {
data "aws_vpc" "default" {
count = local.need_vpc_data ? 1 : 0

id = local.vpc_id
id = var.vpc_id

tags = var.vpc_id
}

data "aws_eip" "nat" {
Expand Down
7 changes: 7 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
variable "vpc_id" {
type = string
description = "VPC ID where subnets will be created (e.g. `vpc-aceb2723`)"
default = null
}

variable "vpc_tags" {

Check warning on line 7 in variables.tf

View workflow job for this annotation

GitHub Actions / terraform-module / CI / Lint (.) 

[tflint] reported by reviewdog 🐶
variable "vpc_tags" is declared but not used

Raw Output:
variables.tf:7:1: warning: variable "vpc_tags" is declared but not used ()

Check warning on line 7 in variables.tf

View workflow job for this annotation

GitHub Actions / terraform-module / CI / Lint (.) 

[tflint] reported by reviewdog 🐶
variable "vpc_tags" is declared but not used

Raw Output:
variables.tf:7:1: warning: variable "vpc_tags" is declared but not used ()
type = map(string)
description = "VPC tags to get the VPC ID where subnets will be created"
default = null
}

variable "igw_id" {
Expand Down
Loading