Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bad .End usages in parser.go #150

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix some bad .End usages in parser.go #150

merged 1 commit into from
Oct 20, 2024

Conversation

makenowjust
Copy link
Collaborator

Related to #149

  • This fixes GeneratedColumnExpr.End(), and now Stored points to the head position of the STORED token.
  • ArraySchemeType.Gt points to the head position of the > token.

Ref #149

- This fixes `GeneratedColumnExpr.End()` and now `Stored` points to the
  head position of the `STORED` token.
- `ArraySchemeType.Gt` points to the head position of the `>` token.
Copy link
Contributor

@apstndb apstndb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a reviewer, but LGTM!
I will resolve conflict #111 with this PR after merge

@makenowjust makenowjust merged commit 82b9d09 into main Oct 20, 2024
4 checks passed
@makenowjust makenowjust deleted the fix-some-end branch October 20, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants