Test for fixing IDs and eliminating private Chat userName #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all remaining DeserializePeerId from CV code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested. Primary focus was to restore ID numbers to not use DeserializePeerId, which was affecting some IDs (beyond 2^31) reported to manage server. Also remove userName on private chats, which was affecting change requests.
I realize this is possibly waiting for major rebase, so no problem if this doesn't get actioned before rebase. But @patriciy if you had a test build with this, I could verify whether it acts correctly for what manage expects.
Also if it is possible to do a test build for 32 bit Windows, there is one user who would appreciate it. That is not high priority though. I think if we did one 32 build, we wouldn't have to maintain it in the future.