Adding the v2/Teams API #6
Conversation
|
Hello, thanks for the work. I am on vacation currently but can check in for a review in the next week. I assume you've already used the new APIs and they work for your own needs? |
|
Hi @danopia! basically, I was writing a script that's using the Teams and the Users API - however, when I found this package I only found the latter being implemented - so I added the former. While I wrote the script I was able to successfully invoke all of the Teams API calls at least once (+ that one v2/users call that I added myself). Does that answer your question? |
| // Common API client contract | ||
| interface ApiClient { | ||
| fetchJson(opts: { | ||
| method: "GET" | "POST" | "DELETE"; |
There was a problem hiding this comment.
It looks like this is the first DELETE call in this project, and so the new method needs to be also added to client.ts:
Line 40 in 657811e
| @@ -10,10 +10,37 @@ export interface ResultPage<T> { | |||
| data: Array<T>; | |||
| } | |||
|
|
|||
| export interface Included { | |||
| export interface TeamsResultPage<T> { | |||
There was a problem hiding this comment.
Did datadog really need to add another pagination structure within v2 😅 LGTM
| async createTeam(name: string): Promise<string> { | ||
| const words = [...name.toLowerCase().matchAll(/[a-z0-9]+/g)].map((x) => x[0]) | ||
| const handle = words.join("-") |
There was a problem hiding this comment.
This is slightly magic. Does this string manipulation follow a particular recommendation from datadog?
Continued:
There was a problem hiding this comment.
oof. I'm afraid I leaked out some business logic from my script here 😅 refactoring in progress
| attributes: { | ||
| name: name, | ||
| handle: handle | ||
| }, |
There was a problem hiding this comment.
I see that there are additional possible attributes for this API, so perhaps we can accept a second optional parameter extraAttributes that lets the caller override handle and/or pass more attributes for the team.
| attributes: { | |
| name: name, | |
| handle: handle | |
| }, | |
| attributes: { | |
| name: name, | |
| handle: handle, | |
| ...extraAttributes, | |
| }, |
Hi! I've noted that in this repo there's no API for v2/Teams, so I added all the GET calls - and also some of the other ones. Please, be kind: this is my literal first OSS contribution in typescript 😅