Skip to content

Commit

Permalink
fix: fixes activity option task queue behavior
Browse files Browse the repository at this point in the history
The previous implementation initiaized the ActivityOptions for the
ExecuteActivity method using the built-in GetActivityOptions helper.
Unfortunately, this helper always returns an ActivityOptions value with
a non-empty task queue that defaults to the workflow task queue, which
prevents the task queue defaulting logic from executing. This change
instead initializes an empty ActivityOptions value and sets the default
task queue to either the value specified by the proto task_field option
or the workflow task queue if no proto value is defined.

closes: #37
  • Loading branch information
cludden committed Apr 9, 2024
1 parent 7304ecf commit 38d49e8
Show file tree
Hide file tree
Showing 18 changed files with 173 additions and 149 deletions.
20 changes: 11 additions & 9 deletions gen/example/helloworld/v1/helloworld_temporal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions gen/example/mutex/v1/mutex_temporal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/example/mutex/v1/mutexv1xns/mutex_xns_temporal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions gen/example/v1/example_temporal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/example/v1/examplev1xns/example_xns_temporal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions gen/example/xns/v1/xns_temporal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/example/xns/v1/xnsv1xns/xns_xns_temporal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 38d49e8

Please sign in to comment.