Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing WaitForCancellation for activity options #57

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

SeJIya
Copy link
Contributor

@SeJIya SeJIya commented Apr 16, 2024

Activity options have WaitForCancellation flag, useful for production when using Cancellation requests, current codegen missing it

potoncial problem for this solution: override value with options from args (same as https://github.com/cludden/protoc-gen-go-temporal/blob/main/internal/plugin/client.go#L1151)

@cludden
Copy link
Owner

cludden commented Apr 16, 2024

This is great! Thanks for updating the docs as well 🙌 ! Re:

potoncial problem for this solution: override value with options from args

I've considered using the native bool wrapper type to support testing for "unset", however, the SDK's bool types don't support this exact test, which means a set default of true in the proto definition would always override an explicit false provided via WithActivityOptions. I'm ok with leaving these as is for now.

@cludden cludden merged commit 89152ec into cludden:main Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants