Use parent task queue (Patch Version 77) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cludden
force-pushed
the
cludden/enable-parent-task-queue-for-child-workflows
branch
from
e798073 to
f92507e
Compare
xaf
approved these changes
Aug 27, 2024
cludden
force-pushed
the
cludden/enable-parent-task-queue-for-child-workflows
branch
from
e82835b to
1cb5f5c
Compare
cludden
changed the title
cludden
force-pushed
the
cludden/enable-parent-task-queue-for-child-workflows
branch
from
1cb5f5c to
005c0f3
Compare
cludden
force-pushed
the
cludden/enable-parent-task-queue-for-child-workflows
branch
from
005c0f3 to
fa6af99
Compare
Closed
xaf
reviewed
Oct 29, 2024
| ) | ||
|
|
||
| func Key[T any](name string, serializable bool) *key { | ||
| return &key{name, serializable, reflect.TypeFor[T]()} |
There was a problem hiding this comment.
You might need to upgrade to go 1.22 to use reflect.TypeFor:
# github.com/cludden/protoc-gen-go-temporal/pkg/ctxkey
pkg/ctxkey/ctxkey.go:22:42: undefined: reflect.TypeFor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a task queue default was configured, it would be used for child workflows and activities, regardless of the parent workflow task queue. Going forward, if this patch version is enabled (default behavior), child workflows and activities will attempt to use the appropriate default based on:
patch.NewContextPropagatoris configured