Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Meson build system. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yegorich
Copy link
Contributor

@yegorich yegorich commented May 6, 2024

This PR is my first attempt to convert the build system to meson based on @kaechele's work. One can compile the library but there is a lot of work to do as all dependencies are marked as required and needed to be converted to the auto type.

@yegorich yegorich force-pushed the meson-conversion branch from 1daa85c to 8aa4406 Compare May 13, 2024 08:25
@yegorich
Copy link
Contributor Author

c++ wraper is now optional.

@yegorich yegorich force-pushed the meson-conversion branch from 8aa4406 to 5b333ac Compare May 13, 2024 12:07
@yegorich yegorich changed the title Work in Progress: Implement Meson build system. Implement Meson build system. May 13, 2024
@yegorich
Copy link
Contributor Author

@cminyard is it possible to build gensio without libpam?

setup_user doesn't seem to be protected with HAVE_LIBPAM.

@cminyard
Copy link
Owner

@cminyard is it possible to build gensio without libpam?

setup_user doesn't seem to be protected with HAVE_LIBPAM.

It doesn't need to be protected in the code, gtlsshd.c won't be compiled if libpam isn't present (on unix). So it is possible to compile without libpam, but gtlsshd.c won't be compiled then.

@cminyard
Copy link
Owner

I'm guessing one of the hardest things you will run into is the ability to exclude a gensio, compile it into the main library, or create a module for it. On an individual gensio basis. Have you thought about this?

Everything else should be doable, I had most of it working with cmake at one point in time.

@yegorich
Copy link
Contributor Author

yegorich commented May 14, 2024

Do you mean this feature? Will have to look at this.

@cminyard
Copy link
Owner

Do you mean this feature? Will have to look at this.

Yes, that's the feature. I was confused at first, the link in the email I got was something completely different. But the link here is right. Strange.

@yegorich
Copy link
Contributor Author

My fault. The other link was in the buffer :-) It was an interesting TV series, though you cannot watch it without a subscription now :-(

ModemManager seems to have the similar plugin architecture: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/blob/main/meson_options.txt?ref_type=heads#L21

@cminyard
Copy link
Owner

cminyard commented May 15, 2024 via email

@cminyard cminyard marked this pull request as ready for review June 6, 2024 23:52
@cminyard
Copy link
Owner

For the record, I started using meson on another project, and it's really an improvement over autotools and make. I'm all for this conversion with what I have learned. I won't have time to work on it in the near future, but if you are willing, I would be happy to take changes for this.

@yegorich
Copy link
Contributor Author

Great to hear this. I'm also busy now. But I'll try to continue my porting effort. The best way would be to merge a minimally wokring set of meson files and then extend it step-by-step. But I still have basic stuff to implement.

@yegorich yegorich force-pushed the meson-conversion branch 2 times, most recently from 674b7b4 to a4135da Compare June 21, 2024 07:09
@yegorich
Copy link
Contributor Author

yegorich commented Jun 21, 2024

Fix SYSCONFDIR compiler option handling.

@yegorich
Copy link
Contributor Author

Set compiler warning level.

Signed-off-by: Felix Kaechele <felix@kaechele.ca>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
@yegorich
Copy link
Contributor Author

@cminyard I have implemented a concept of all-gensios for a subset of gensios. Let me know if it is woriking as expected. Then, I can complete it for other gensios.

@yegorich
Copy link
Contributor Author

@cminyard forget about it. I thought too complicated :-) Stay tuned.

@cminyard cminyard force-pushed the master branch 3 times, most recently from 31b7616 to e4dbb96 Compare September 7, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants