-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NGT] Implement NanoAOD
ntuples production for HLT Muon objects
#47069
base: master
Are you sure you want to change the base?
Conversation
Include HLT L2 Muon offline seeds in the event content to compare them with the ones from L1Tk Muons
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47069/43241 |
A new Pull Request was created by @Parsifal-2045 for master. It involves the following packages:
@AdrianoDee, @Moanwar, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @ftorrresd, @hqucms, @mandrenguyen, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type ngt |
enable nano |
please test |
@@ -702,6 +702,7 @@ def SwapKeepAndDrop(l): | |||
phase2_muon.toModify(FEVTDEBUGHLTEventContent, | |||
outputCommands = FEVTDEBUGHLTEventContent.outputCommands + [ | |||
'keep recoMuons_muons1stStep_*_*', | |||
'keep *_hltL2OfflineMuonSeeds_*_*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be saved regardless or can it be (for the time being) gated through the phase2L2AndL3Muons
modifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually the other way around. The collection is not produced when using the phase2L2AndL3Muons
procModifier, but I decided to produce ntuples also for the both the current muon seeds collections, namely the "offline" one and the one from L1Tk Muons (at least for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collection is not produced when using the phase2L2AndL3Muons procModifier,
I then suggest to apply the reverse modifier, that way it will be easier to remove once it's re-absorbed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collection is not produced when using the phase2L2AndL3Muons procModifier,
I then suggest to apply the reverse modifier, that way it will be easier to remove once it's re-absorbed.
What's the correct syntax for that? I now have (phase2Muon and not phase2L3AndL3Muons).toModify...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the syntax for that?
(phase2Muon & ~phase2L2AndL3Muons).toModify(...)
(OTOH, I am not formally a reviewer of this PR, so I let the @cms-sw/operations-l2 decide what's best -- incidentally ever increasing the size of FEVTDEBUGHLTEventContent
will inevitably lead to operation issues when trying to run big MC samples production )
+1 Size: This PR adds an extra 60KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+Upgrade |
PR description:
This PR allows to produce, on-demand, ntuples in
NanoAOD
format for all HLT muon objects, including L1TkMuons and all the new collections introduced by #46897.The production is triggered automatically when running .777 or .778 workflows. Otherwise, it can be triggered by adding
NANO:@MUHLT
as a step in any step2cmsDriver
command, together with the addition ofNANOAODSIM
in bothdatatier
andeventcontent
.PR validation:
No physics changes are foreseen.
I've tested on the usual 29834 and 29850 workflows also in their .777 and .778 flavours, in all cases the workflows run and ntuples are produced correctly
.0 workflows require to manually trigger the nutples production using, for example: