-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CL Containment Chamber De-Metagamifyer #7427
Conversation
Ill figure out why it's failing tests tomorrow, it worked just fine on local so... we'll have to see |
ah, that'd be it |
WE ARE CLEAR FOR TAKEOFF! |
It doesn't conflict with the psych ward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mapping lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
Yippee! |
About the pull request
This PR makes it so that MPs will no longer have any justification to metagame the corporate liaison's containment cell without it being EXTREMELY obvious.
The containment cell's divider now just looks like an ordinary wall, and it has a custom opening and closing sprite for that purpose.
The button for the containment cell has also been moved to the back office, as has the control panel to access it. The button has been replaced with a button for the back office shutters, and the console has been replaced with a TV (a thing liaisons have wanted stock standard in their office ever since Combat Correspondent was added).
This PR also changes some minor stuff around the CL's office to make it cleaner, and adds a WY-MRE to the cabinet, as the office had no food in it for some reason (which has caused a few new liaisons to eat the monkey cubes, thinking they were food cubes).
Finally, I also changed the containment cell's area name to "Storage Room" so if an MP is snooping around the liquor cabinet, they don't see "Containment Cell APC."
The PR contains mapping changes, of course. I know Alaymer Mapping changes are supposed to be frozen, but I asked Nanu and he specifically said something like this would be minor enough (and useful enough) to be acceptable.
I tested all the changes and used mapmerge.
This PR also includes sprite additions. They shouldn't conflict with blundir's sprite freeze, as i asked him and he said the file i modified wasn't included in the pr. He can weigh in personally to confirm that.
Explain why it's good for the game
MPs metagaming the existence of the containment cell is extremely annoying, and no one likes it. Making it much harder for them to just say "CL open the containment cell" or "HMM, what does this button labelled CONTAINMENT SHUTTERS on your desk DO???" is a good change.
Also the CL not having any food in his office is a tad weird, I feel like some donks in the back makes sense
same with the TV, every CL player has wanted a TV in their office roundstart since CC was added
Testing Photographs and Procedure
Screenshots & Videos
this video doesn't properly show the desk configuration, but it shows the animation quite well. (it was an old video)
xUVoud3.mp4
Changelog
🆑
imageadd: added a new sprite for the liaison's wall divider behind his desk
mapadd: added a WY mre to the liaison's liquor cabinet (cardboard box full of donk pockets)
mapadd: added a tv to the liaison's desk, in place of the containment cell console
mapadd: added a new button to the liaison's desk to replace the wall divider button. it controls the back office shutters
maptweak: moved the liaison's shutters button and console to the back office
maptweak: moved some stuff around in the liquor cabinet to accommodate the MRE being placed into it
maptweak: moved some stuff around on the liaison's desk to make it look cleaner
/:cl: