Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hivecore restriction #7451

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Oct 31, 2024

About the pull request

This PR is a follow up to #7363 where a hive core placement restriction had no effect. I also cleaned up a couple edge cases where the construction template would not get deleted on construction failure.

Explain why it's good for the game

Restrictions should actually work.

Testing Photographs and Procedure

Screenshots & Videos

core
core2

Changelog

🆑 Drathek
fix: Fix hive core placement restriction
/:cl:

@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Oct 31, 2024
@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Oct 31, 2024
cm13-github added a commit that referenced this pull request Oct 31, 2024
cm13-github added a commit that referenced this pull request Oct 31, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would nanu do this…

cm13-github added a commit that referenced this pull request Oct 31, 2024
@Nanu308
Copy link
Member

Nanu308 commented Nov 1, 2024

Code approved by HarryOb, mergeable af

@Nanu308 Nanu308 added this pull request to the merge queue Nov 1, 2024
Merged via the queue into cmss13-devs:master with commit 86ba252 Nov 1, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Nov 1, 2024
@Drulikar Drulikar deleted the Fix_Hivecore_Restriction branch November 1, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants