Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the python covidcast client in validator #1972

Open
melange396 opened this issue Jun 6, 2024 · 2 comments
Open

replace the python covidcast client in validator #1972

melange396 opened this issue Jun 6, 2024 · 2 comments
Assignees
Labels
refactor Long-term projects to revise existing machinery

Comments

@melange396
Copy link
Contributor

Similar to #1931, the python covidcast client (which has some issues) is used in the delphi_utils.validator submodule and it can should come out of there:

@melange396 melange396 added the refactor Long-term projects to revise existing machinery label Jun 6, 2024
@melange396
Copy link
Contributor Author

melange396 commented Jun 28, 2024

One interesting quirk of the covidcast client is that it pins "pandas<2", which nets version 1.5.3 (from ~1.5y ago)...

I find no reason/rationale for this in either the source or comments of cmu-delphi/covidcast#618 where the change was made :(

This also means that anything that imports the delphi_utils package inherits the version restriction.

The current version of Pandas is 2.2.2 -- which might offer significant performance improvements, but it risks breaking any number of things. Pandas is not pinned anywhere in this repo (except for the now-toothless spec in delphi_utils to >=1.1.0), so completing this issue may require changes or pinning in individual indicator code. EDIT: version pinning issue #1967 may be relevant for this.

@melange396
Copy link
Contributor Author

#1985 is an effective stop-gap for removing the dependency implications (and it also partially fulfills #1931 and #1987 ), but it doesnt address the covidcast client inefficiencies mentioned in #1931...

to properly satisfy that , i think it should be sufficient to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Long-term projects to revise existing machinery
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants