refactor: bundle covidcast==0.2.2 in delphi_utils #1985
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tried adding a simple wrapper around
delphi_epidata.Epidata
in here to avoidcovidcast
, but it grew to become most of thecovidcast
client from the other repo. So I just bundled thecovidcast==0.2.2
in here, which removes transitive dependencies on plotting and geo libaries and unpins Pandas, but also doesn't require us to do any new testing of the client library.Eventually, we should replace this with epidatpy, but that is possibly months from release.
The main thing we should pay attention to is the Pandas version changing our code behavior (both in client and in indicator pipelines) - we went from pandas-1.5.3 to pandas-2.0.3 (in CI below; not sure why it didn't go up to 2.2.x, pip might just prefer installing a cached version that satisfies the resolver). The unit tests pass below, but it's possible they missed some things. We'll need to look at what behaviors changed from 1.5.3 to 2.0.0. Or we can just pin to 1.5.3 and punt the Pandas bump to another PR.
Changelog
Fixes