-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title argument to plotting function #363
base: plotting-ax
Are you sure you want to change the base?
Conversation
Hmm. Is there a way to set a subtitle? Because it seems like a good strategy would be to take a custom title and let the subtitle be date. Otherwise, if you set a title, the date doesn't get displayed at all, right? |
matplotlib has a suptitle() (yes with a Alternatively you can add a \n and that will lead to a second line. Is it a big problem if there's no date? A user always has the option to add the date, and if we force it in the subtitle and they don't want it, that could be annoying. The one case where I could see it making sense is when you pass in a df with multiple dates and it uses the most recent time value, having it tell you that date could be useful. However, we could also achieve that with a message/warning of some sort. |
Ah, sorry, I was thinking of the animation method for some reason, maybe because it was being discussed on Slack. There it's important to have a date appear somewhere, because otherwise you have no idea which frame corresponds to what date. |
Good point. Maybe we add an optional |
This looks like a backwards-compatible change. Do we want to fix and merge or close? @capnrefsmmat |
Based off #361, so based for this PR should be switched to main and merged after it. Fixes #360.
Summary of changes: