Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Docker compose, use in Makefile, try in CI #1315

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: add Docker compose, use in Makefile, try in CI #1315

wants to merge 1 commit into from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Oct 13, 2023 •
edited
Loading

Summary:

Implements two ideas:

  • using a docker compose file to simplify the dev Makefile
  • unifying CI by using the Makefile.

Improves things by:

  • making sure we don't need to update CI when we update the Docker commands
  • simplifying the Makefile itself
  • moving our Docker configuration out of one long line with a bunch of flags and into an easier-to-read docker-compose.yaml file

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dshemetov dshemetov mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 Awaiting requested review from melange396

@rzats rzats Awaiting requested review from rzats

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dshemetov