Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid linking keywords in PR template #1504

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

melange396
Copy link
Collaborator

Certain phrasing in a PR can "link" it to a particular issue. Merging a PR that is "linked" to an issue will automatically close that issue. This can be handy, but it can also be problematic if the issue is closed unintentionally, like when a PR does not completely cover all of the points made in the issue. For examples of this, see: cmu-delphi/covidcast-indicators#1676 (comment) and cmu-delphi/covidcast-indicators#1973 (comment) . The automatic closing behavior can not be disabled, though it is a commonly requested feature. This PR removes those linking keywords from the template to reduce the possibility of an undesired linking.

@melange396 melange396 added bug documentation code health readability, maintainability, best practices, etc labels Jul 25, 2024
Copy link

sonarcloud bot commented Jul 25, 2024

@melange396 melange396 merged commit 3e39e22 into dev Jul 26, 2024
7 checks passed
@melange396 melange396 deleted the pr_template_keyword_removal branch July 26, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code health readability, maintainability, best practices, etc documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants