Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wastewater core #1513

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Wastewater core #1513

wants to merge 5 commits into from

Conversation

dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Aug 7, 2024

originating from an issue over in covidcast-indicators

Summary:

This adds a new endpoint for wastewater data, initially just NWSS data at the finest resolution, as described in the wastewater PRD. It also adds any notes I've picked up about endpoint development.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted
  • squash merge

Ongoing:

Very much a draft at the moment. here's a list of the tasks:

  • write acquisition code
    • extract
    • transform
    • load
  • write API code
  • test acquisition code
  • test sql code
  • integration tests
    Things that will wait until a later PR/occur in different endpoints
  • add endpoint to clients
  • update epidata documentation
  • PR to add generic utils to delphi_utils (e.g. sig_digit_round`)
  • add the aggregated signal

Open to suggestion of things that should go into the ongoing pile, as docs for adding endpoints are somewhat sparse.

@dsweber2 dsweber2 self-assigned this Aug 9, 2024
@dshemetov dshemetov self-requested a review August 22, 2024 16:35
@dsweber2
Copy link
Contributor Author

In case you're taking a look, the files that are ready are

  • nwss_csv.py
  • nwss_constants.py
  • nwss_database.py
  • epidata_development.md
  • new_endpoint_tutorial.md
  • wastewater.sql

Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.3% Duplication on New Code (required ≤ 20%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant