Fix rendering bugs in feedback report

cmu-sei · Dec 12, 2024 · 3622fb1 · 3622fb1
1 parent aeb902b
commit 3622fb1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 19 deletions.
diff --git a/.../app/feedback/components/feedback-submission-form/feedback-submission-form.component.html b/.../app/feedback/components/feedback-submission-form/feedback-submission-form.component.html
@@ -7,7 +7,7 @@
             <small><span class="font-weight-bold align-middle">{{template?.helpText}}</span></small>
         </div>
 
-        <ng-container *ngIf="!submission.whenFinalized; else finalized">
+        <ng-container *ngIf="!submission.whenFinalized && !isAdminView; else finalized">
             <div *ngFor="let q of submission.responses; let i = index" class="mb-4">
                 <label for="{{q.id}}">
                     <div class="d-flex">

diff --git a/...oard-ui/src/app/reports/components/reports/feedback-report/feedback-report.component.html b/...oard-ui/src/app/reports/components/reports/feedback-report/feedback-report.component.html
@@ -107,11 +107,3 @@
 </ng-template>
 <ng-template #noValue>--</ng-template>
 <ng-template #loading><app-spinner>Loading player feedback...</app-spinner></ng-template>
-
-<ng-template #playerResponsesModal let-context>
-    {{ context | json }}
-    <!-- <app-modal-content title="Feedback" [subtitle]="context.user.name">
-        <app-feedback-submission-form [templateId]="ctx.parameters.templateId"
-            [feedbackEntity]="context.entity"></app-feedback-submission-form>
-    </app-modal-content> -->
-</ng-template>
diff --git a/...eboard-ui/src/app/reports/components/reports/feedback-report/feedback-report.component.ts b/...eboard-ui/src/app/reports/components/reports/feedback-report/feedback-report.component.ts
@@ -77,15 +77,13 @@ export class FeedbackReportComponent extends ReportComponentBase<FeedbackReportP
   };
 
   protected handleRecordClick(record: FeedbackReportRecord) {
-    if (this.playerResponsesModalTemplate) {
-      this.modalService.openComponent({
-        content: PlayerFeedbackResponsesModalComponent,
-        context: {
-          record,
-          templateId: this.ctx.parameters.templateId
-        }
-      });
-    }
+    this.modalService.openComponent({
+      content: PlayerFeedbackResponsesModalComponent,
+      context: {
+        record,
+        templateId: this.ctx.parameters.templateId
+      }
+    });
   }
 
   protected async updateView(parameters: FeedbackReportParameters): Promise<ReportViewUpdate> {

diff --git a/...ack-report/player-feedback-responses-modal/player-feedback-responses-modal.component.html b/...ack-report/player-feedback-responses-modal/player-feedback-responses-modal.component.html
@@ -1,4 +1,4 @@
-<app-modal-content *ngIf="record" title="Feedback" [subtitle]="record.user.name">
+<app-modal-content *ngIf="record" title="Feedback" [subtitle]="record.user.name" [hideCancel]="true">
     <app-feedback-submission-form [templateId]="templateId" [isAdminView]="true"
         [feedbackEntity]="record.entity"></app-feedback-submission-form>
 </app-modal-content>