Feedback Report responses dialog now clarifies when feedback hasn't b…

…een finalized
cmu-sei · Dec 13, 2024 · bc5ae34 · bc5ae34
1 parent 42feef1
commit bc5ae34
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/...src/app/reports/components/reports/feedback-game-report/feedback-game-report.component.ts b/...src/app/reports/components/reports/feedback-game-report/feedback-game-report.component.ts
@@ -92,7 +92,7 @@ export class FeedbackGameReportComponent extends ReportComponentBase<FeedbackGam
 
     return {
       metaData: {
-        key: ReportKey.FeedbackReport,
+        key: ReportKey.FeedbackReportLegacy,
         title: "Feedback Report (Legacy)",
         description: "",
         isExportable: true,

diff --git a/...eboard-ui/src/app/reports/components/reports/feedback-report/feedback-report.component.ts b/...eboard-ui/src/app/reports/components/reports/feedback-report/feedback-report.component.ts
@@ -77,13 +77,13 @@ export class FeedbackReportComponent extends ReportComponentBase<FeedbackReportP
   };
 
   protected handleRecordClick(record: FeedbackReportRecord) {
-    console.log("opening record", record);
     this.modalService.openComponent({
       content: PlayerFeedbackResponsesModalComponent,
       context: {
         record,
         templateId: this.ctx.parameters.templateId
-      }
+      },
+      modalClasses: ["modal-xl"]
     });
   }
 

diff --git a/...ack-report/player-feedback-responses-modal/player-feedback-responses-modal.component.html b/...ack-report/player-feedback-responses-modal/player-feedback-responses-modal.component.html
@@ -1,12 +1,17 @@
 <app-modal-content *ngIf="record" title="Feedback" [subtitle]="record.user.name" [hideCancel]="true">
+    <alert *ngIf="!record.whenFinalized" type="warning" class="my-4">
+        This player hasn't finalized their submission yet - it may change if they submit it later.
+    </alert>
     <ol>
         <li *ngFor="let response of record.responses; index as i" class="my-4">
             <strong>{{ i + 1 }}. {{ response.prompt }}</strong>
-            <div class="my-2" *ngIf="response.answer">{{ response.answer }}</div>
+            <div class="my-2" *ngIf="response.answer; else noResponse">{{ response.answer }}</div>
         </li>
     </ol>
 </app-modal-content>
 
 <ng-template #noResponse>
-    <em>(no response)</em>
+    <div>
+        <em>(no response)</em>
+    </div>
 </ng-template>