Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
linkml-runtimetests print many ominous warnings like:This is because a file object is
opened without ever being closed.Not closing files is safer when reading from them than when writing to them, but it still keeps files locked, uses additional file handles, and can still corrupt files in rare cases on crashes.
this PR splits the function in two and uses a context manager when the thing passed to us is a string. It still allows someone to pass an open file handle to the function, but otherwise raises a
ValueError