localize service.md file in russian language #3347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.42.0 to 0.44.0. - [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases) - [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md) - [Commits](rojopolis/spellcheck-github-actions@0.42.0...0.44.0) --- updated-dependencies: - dependency-name: rojopolis/spellcheck-github-actions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…polis/spellcheck-github-actions-0.44.0 Bump rojopolis/spellcheck-github-actions from 0.42.0 to 0.44.0
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yashisrani
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
|
Hi @yashisrani Commit sha: 83bd17a, Author: Yash Israni, Committer: Yash Israni; The sign-off is missing. sign-off is mandatory for contributing to the cloud native glossary. :_ |
shurup
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Hi @yashisrani, and thank you for your effort!
Can you please confirm that you made this translation manually? The translation I can see now seems to have been auto-generated or created by a non-native speaker.
We also should not mix the translations themselves with any other fixes (e.g., in the .github/workflows directory) in one PR since these changes are not related and can cause confusion when reviewing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I created a service.md file in the "content/ru" path and localized the service.md file in Russian language with the right terms.
Related issue number or link (ex:
resolves #issue-number)issue #3334
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".