Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus remote write project for june 2024 #1218

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

cstyan
Copy link
Contributor

@cstyan cstyan commented Apr 25, 2024

Project for upcoming summer session related to benchmark testing of Prometheus Remote Write. Not sure if @jesusvazquez is already registered on the LFX mentorship platform.

Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @cstyan!

Could you provide an upstream issue as well? This helps a couple ways: when I load this into LFX I need a link to the projcect, and it gives folks a place to ask questions or comment on the work.

Also, @jesusvazquez, could you give a 👍 or approve this PR as your confirmation of wanting to participate? (Nico & Alex, you too--I just don't have your GitHub handles to tag you 🙂)

@cstyan
Copy link
Contributor Author

cstyan commented Apr 26, 2024

cc @npazosmendez @alexgreenbank

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan
Copy link
Contributor Author

cstyan commented Apr 26, 2024

Could you provide an upstream issue as well? This helps a couple ways: when I load this into LFX I need a link to the projcect, and it gives folks a place to ask questions or comment on the work.

Done 👍 it didn't exist before so I just created one under the umbrella of our larger remote write 2.0 work meta issue as that's the original context this project came up in.

Tagged Nico and Alex as well. They'll likely be working on other portions of the remote 2.0 implementation itself, and so will have less time for direct mentoring but just as much context around the use case of what the mentee would be building. Jesús has context around prombench itself.

- Callum Styan (@cstyan, callumstyan@gmail.com),
- Jesús Vázquez (@jesusvazquez, jesus.vazquez@grafana.com)
- Nico Pazos and Alex Greenbank from Grafana also available to help

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Upstream Issue: https://github.com/...

@cstyan can you add the upstream issue here please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created one under the umbrella of our larger remote write 2.0 work meta issue as that's the original context this project came up in.

If you can drop it in here I can merge it in 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, made the change locally last night but forgot to pushy, the link is there now

@alexgreenbank
Copy link

👍 Happy to be involved!

Copy link
Contributor

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusvazquez
Copy link
Contributor

Hey @cstyan I'm registered in the LFX platform already 👍

@nate-double-u just approved 👍

@npazosmendez
Copy link

Happy to be involved too!

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

Signed-off-by: Nate W <natew@cncf.io>
@nate-double-u nate-double-u merged commit ca2397a into cncf:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants