Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image Signing From K8s RelEng #1230

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

puerco
Copy link
Contributor

@puerco puerco commented May 7, 2024

This commit adds to the project ideas a proposal from Kubernetes Release Engineering. We are seeking help to fix image signatures in our image promotion process.

/hold
For final RelEng review
/cc @mehabhalodiya

@mehabhalodiya
Copy link
Contributor

+1, I'm in support of this.

cc @nate-double-u @aliok

@puerco
Copy link
Contributor Author

puerco commented May 7, 2024

@nate-double-u @aliok is it possible to add more than one two mentors? This project will likely require more than the two of us.

@aliok
Copy link
Member

aliok commented May 7, 2024

@puerco add as many as you like!
We're ready to merge this one, but I am waiting for you to update the PR with new mentors.

@mehabhalodiya
Copy link
Contributor

@puerco Please add @xmudrii to the mentor's list. He will be going to help as much as he can without a doubt and he also confirmed that he'll have plenty of time capacity for image promoter work. 🙂
Thank you!

@puerco
Copy link
Contributor Author

puerco commented May 7, 2024

OK, I've added @xmudrii and @jeremyrickard to the list of mentors

@jeremyrickard
Copy link
Contributor

jeremyrickard commented May 7, 2024

+1 from me with SIG Release Chair Hat on

@puerco
Copy link
Contributor Author

puerco commented May 7, 2024

OK, I stupidly added /hold to note that we were still working on it not realizing we don't have prow here, sorry about that!@ 🙃

@aliok we're ready to go with this one, we discussed the proposal and plan on the SIG Release meeting on May 7th and we're on.

This commit adds to the project ideas a proposal from Kubernetes
Release Engineering. We are seeking help to fix image signatures
in our image promotion process.

Co-authored-by: Jeremy Rickard <jrickard@microsoft.com>
Co-authored-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Co-authored-by: Meha Bhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
@nate-double-u
Copy link
Member

nate-double-u commented May 7, 2024

Since this is a proposal for a Kubernetes project, I think we'll need the sig-contribex leads approval as well. Usually we'd require a project maintainer's approval, but things are a touch different with K8s projects and subprojects. @kaslin & @palnabarun, if you could both take a look.

(Not to put one SIG over another, mentorship is SIG Contribex's area, and I want to make sure there's no inadvertent overlap)

@justaugustus
Copy link

Another SIG Release Chair +1 from me!

@nate-double-u
Copy link
Member

OK, I stupidly added /hold to note that we were still working on it not realizing we don't have prow here, sorry about that!@ 🙃

I do the same thing 😂

@aliok aliok merged commit e1658d3 into cncf:main May 7, 2024
2 checks passed
@aliok
Copy link
Member

aliok commented May 7, 2024

Thanks folks!

@kaslin
Copy link

kaslin commented May 7, 2024

Oops, we never did respond here. I don't think SIG ContribEx approval is explicitly required, but as long as the folks running it believe it makes sense and are excited to do it, we're happy to offer our approval!

@kaslin
Copy link

kaslin commented May 7, 2024

We do also appreciate being involved so we can try to keep track of mentoring efforts going on in the project, so maybe requiring SIG ContribEx approval is the way to achieve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

7 participants