Vitess community project for LFX 2024 Jun-Aug #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepthi <deepthi@planetscale.com>
aliok
reviewed
May 8, 2024
| - Mentor(s): | ||
| - Deepthi Sigireddi @deepthi deepthi@planetscale.com | ||
| - Florent Poinsard @frouioui florent@planetscale.com | ||
| - Upstream Issue (URL): N/A |
There was a problem hiding this comment.
+1 it's important to have an upstream issue for candidates to see what they're getting into. It's also helpful as a spot to have conversations about the work.
There was a problem hiding this comment.
(also, we need an upstream issue to link to when we load the project into the LFX platform)
There was a problem hiding this comment.
@aliok I have actually created 2 issues, but one is linked into the other, so I've only added the main issue into the proposal.
aliok
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @frouioui