Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Copacetic Project for LFX 2024 Jun-Aug #1237

Merged
merged 4 commits into from
May 9, 2024

Conversation

ashnamehrotra
Copy link
Contributor

@ashnamehrotra ashnamehrotra commented May 8, 2024

Proposal for Copacetic Project for LFX 2024 Jun-Aug

Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
@aliok
Copy link
Member

aliok commented May 8, 2024

Thanks @ashnamehrotra! I will need these before merging this PR:

@nate-double-u
Copy link
Member

/cc @jeremyrickard, @salaxander, @sozercan

- Mentors(s):
- Ashna Mehrotra (@ashnamehrotra, asmehrotra@microsoft.com)
- Robert Kielty (@RobertKielty, robert.kielty@cncf.io)
- Upstream Issues: https://github.com/project-copacetic/copacetic/issues?q=is%3Aissue+is%3Aopen+%5BREQ%5D+created%3A%3E2024-05-01+ and https://github.com/project-copacetic/copacetic/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to suggest using one upstream issue that acts as an umbrella issue. We need a specific issue to link to when we load the proposal into the LFX platform, and a single issue also acts as a focus point for candidates to see the work and discuss how it may be done.

Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
@MiahaCybersec
Copy link

MiahaCybersec commented May 9, 2024

It appears that the maintainers list utilized by the CNCF for Copa was not updated. The list referenced by the CNCF (https://github.com/cncf/foundation/blob/main/project-maintainers.csv) names Sertac, Xander, and Jeremy.

However, the spreadsheet references the code owners file (https://github.com/project-copacetic/copacetic/blob/main/CODEOWNERS) which lists Jeremy, Sertac, and Ashna.

While I'm not aware of the process for updating this, I felt it was important to mention this in the context of this PR.

@RobertKielty RobertKielty self-assigned this May 9, 2024
@aliok
Copy link
Member

aliok commented May 9, 2024

Thanks @MiahaCybersec , so we got our maintainer approver already!

Merging this one then.

aliok added 2 commits May 9, 2024 21:04
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
@nate-double-u
Copy link
Member

Could one of the maintainers update the CNCF list linked above? It's important to keep it up to date. To update it all you need is a PR to CNCF/foundation

@aliok aliok enabled auto-merge (squash) May 9, 2024 18:11
@ashnamehrotra
Copy link
Contributor Author

Could one of the maintainers update the CNCF list linked above? It's important to keep it up to date. To update it all you need is a PR to CNCF/foundation

Created a PR to update: cncf/foundation#797

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating cncf/foundation 🙂

@aliok aliok merged commit 20b4c61 into cncf:main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants