-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LFX Summer 2024: Service Mesh Performance #1246
Conversation
Signed-off-by: Yash sharma <71271069+Yashsharma1911@users.noreply.github.com>
Hi @Yashsharma1911, thanks for this! @leecalcote & @gyohuangxin could you 👍 or approve this PR to confirm your participation? |
Also, @Yashsharma1911, could you resolve the merge conflicts? |
Signed-off-by: Yash sharma <71271069+Yashsharma1911@users.noreply.github.com>
Signed-off-by: Yash sharma <71271069+Yashsharma1911@users.noreply.github.com>
Signed-off-by: Yash sharma <71271069+Yashsharma1911@users.noreply.github.com>
Thankyou @nate-double-u merge conflicts are now resolved |
Signed-off-by: Yash sharma <71271069+Yashsharma1911@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the update, we're still waiting on a 👍 or approval from @gyohuangxin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should target programs/lfx-mentorship/2024/02-Jun-Aug/project_ideas.md
, part of our process is moving from project ideas to the README as the LFX approves the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @Yashsharma1911
/approve
/hold
(hold while we wait for confirmation from @gyohuangxin)
Signed-off-by: Yash Sharma <yashsharma2572@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.