Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept any password during tests #193

Merged
merged 3 commits into from
Jan 10, 2024
Merged

feat: accept any password during tests #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ed651f
feat: accept any password during tests
arnou Dec 11, 2023
a4bc1f1
Merge branch 'master' into accept-any-password
arnou Jan 8, 2024
bcebfd8
Merge branch 'master' into accept-any-password
arnou Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions ...cnieg/keycloak/providers/login/attribute/authenticator/AttributeUsernamePasswordForm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package fr.cnieg.keycloak.providers.login.attribute.authenticator;

import jakarta.ws.rs.core.MultivaluedMap;
import jakarta.ws.rs.core.Response;
import org.jboss.logging.Logger;
import org.keycloak.authentication.AuthenticationFlowContext;
import org.keycloak.authentication.AuthenticationFlowError;
Expand All @@ -8,16 +10,14 @@
import org.keycloak.authentication.authenticators.browser.UsernamePasswordForm;
import org.keycloak.events.Details;
import org.keycloak.events.Errors;
import org.keycloak.models.AuthenticatorConfigModel;
import org.keycloak.models.ModelDuplicateException;
import org.keycloak.models.UserModel;
import org.keycloak.models.utils.KeycloakModelUtils;
import org.keycloak.services.ServicesLogger;
import org.keycloak.services.managers.AuthenticationManager;
import org.keycloak.services.messages.Messages;

import jakarta.ws.rs.core.MultivaluedMap;
import jakarta.ws.rs.core.Response;

import static fr.cnieg.keycloak.AuthenticatorUserModel.getUserModel;

/**
Expand All @@ -36,13 +36,17 @@ public class AttributeUsernamePasswordForm extends UsernamePasswordForm implemen
* Attribute format
*/
public static final String ATTRIBUTE_REGEX = "login.attribute.regex";
/**
* Authorize any password
*/
public static final String AUTHORIZE_ANY_PASSWORD = "authorize.any.password";

private UserModel getUserByAttribute(AuthenticationFlowContext context, String userName) {
return getUserModel(context, userName, ATTRIBUTE_KEY, ATTRIBUTE_REGEX);
}

/**
* @param context Authentication Flow context
* @param context Authentication Flow context
* @param inputData User inputs
* @return password checked
*/
Expand All @@ -51,17 +55,30 @@ public boolean validateUserAndPassword(AuthenticationFlowContext context, Multiv
logger.debug("validateUserAndPassword()");
context.clearUser();
UserModel user = getUserOrAttribute(context, inputData);
return user != null && validatePassword(context, user, inputData, true) && validateUser(context, user, inputData);
return user != null &&
validateUser(context, user, inputData) &&
(validateAnyPassword(context) || validatePassword(context, user, inputData, true));
}

private boolean validateAnyPassword(AuthenticationFlowContext context) {
AuthenticatorConfigModel config = context.getAuthenticatorConfig();
if (config != null) {
if (Boolean.parseBoolean(config.getConfig().get(AUTHORIZE_ANY_PASSWORD))) {
logger.warn("Password not validated, use this configuration only for tests purpose");
return true;
}
}
return false;
}

/**
* @param context Authentication Flow context
* @param context Authentication Flow context
* @param inputData User inputs
* @return password checked
*/
@Override
public boolean validateUser(AuthenticationFlowContext context, MultivaluedMap<String, String> inputData) {
logger.debug("validateUserAndPassword()");
logger.debug("validateUser()");
context.clearUser();
UserModel user = getUserOrAttribute(context, inputData);
return user != null && validateUser(context, user, inputData);
Expand Down
15 changes: 11 additions & 4 deletions ...eycloak/providers/login/attribute/authenticator/AttributeUsernamePasswordFormFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package fr.cnieg.keycloak.providers.login.attribute.authenticator;

import java.util.ArrayList;
import java.util.List;

import org.keycloak.Config;
import org.keycloak.authentication.Authenticator;
import org.keycloak.authentication.AuthenticatorFactory;
Expand All @@ -12,6 +9,9 @@
import org.keycloak.models.credential.PasswordCredentialModel;
import org.keycloak.provider.ProviderConfigProperty;

import java.util.ArrayList;
import java.util.List;

/**
* Form factory for Attribute Username Password
*/
Expand Down Expand Up @@ -136,10 +136,17 @@ public String getHelpText() {
providerConfigProperty.setHelpText("Regular expression for which the search by attribute will be performed");
providerConfigProperty.setDefaultValue(".*");
CONFIG_PROPERTIES.add(providerConfigProperty);
providerConfigProperty = new ProviderConfigProperty();
providerConfigProperty.setName(AttributeUsernamePasswordForm.AUTHORIZE_ANY_PASSWORD);
providerConfigProperty.setLabel("Authorize Any Password");
providerConfigProperty.setType(ProviderConfigProperty.BOOLEAN_TYPE);
providerConfigProperty.setHelpText("Add ability (only for tests) to accept any password");
providerConfigProperty.setDefaultValue(false);
CONFIG_PROPERTIES.add(providerConfigProperty);
}

@Override
public List<ProviderConfigProperty> getConfigProperties() {
return CONFIG_PROPERTIES;
}
}
}