Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use epics-in-docker IOC build workflow. #5

Merged
merged 1 commit into from
Mar 18, 2024
Merged

ci: use epics-in-docker IOC build workflow. #5

merged 1 commit into from
Mar 18, 2024

Conversation

henriquesimoes
Copy link
Collaborator

The workflow is configured to use Git tags to push tagged images to the registry.

The workflow is configured to use Git tags to push tagged images to the
registry.
@henriquesimoes
Copy link
Collaborator Author

@ericonr, it seems the tagging mechanism does not work as we expected when triggered by pull_request. github.ref_name is being resolved to 5/merge (which is an invalid image tag), since that is the pattern for PRs.

Is there any way to define a given environment variable in a single trigger? I found a way to define optional inputs, but I'm not sure if there is a better option.

@ericonr
Copy link
Member

ericonr commented Mar 13, 2024

Hmm, it seems we should have used something like what we have for the base images... https://github.com/cnpem/epics-in-docker/blob/95df0a597bf9cb2c658645439984e4a4a8c64ce2/.github/workflows/base-image.yml#L23

@henriquesimoes
Copy link
Collaborator Author

Good point. That seems a cleaner solution ;)

@henriquesimoes henriquesimoes merged commit 49a96e8 into main Mar 18, 2024
1 of 2 checks passed
@henriquesimoes henriquesimoes deleted the ci branch March 18, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants