Conversation
a1d2306 to
9af49c9
Compare
ericonr
left a comment
There was a problem hiding this comment.
commit message:
base: add support for ADEiger module.
base: add ADEiger module.
ZeroMQ library development package is required in the build stage of
ADEiger module.
This module uses libzmq to interact with the detector data stream.
(this way you justify the presence of the -dev package and the runtime package in your runtime image)
There are some unreleased features we would like to use, regarding
Pilatus4 support, what makes necessary a checkout after initializing the
submodule. The EDEIGER_VERSION points to the latest commit, but should
point to R3-6 when the version were tagged.
Since Pilatus4 support hasn't been released yet and we are interested in using
it, we are using the latest commit from the master branch instead of a tagged
release.
9af49c9 to
a2c24f4
Compare
a2c24f4 to
6e22f36
Compare
ericonr
left a comment
There was a problem hiding this comment.
I think tagging a new release is pending on further driver changes, right? So we have to use a commit for now.
6e22f36 to
08a1970
Compare
Yeap, discussed here: areaDetector/ADEiger#70 (comment) |
|
Well, there is something for us to choose here. Does this need to be merged before the tag? We're perfectly capable of building the IOC image ourselves, and use it for commissioning tests in the beamline. In the meantime, we can try and move along the missing functionality, so we can have everything merged before the machine stop ends. |
Since we are talking about commissioning tests, there is no hurry on merging this, IMHO. (This is actually the reason for leaving this PR as draft on the first time) But when comes the time to the official deploy for operation, if it hasn't been tagged yet, then we should use the untagged version. |
08a1970 to
5736122
Compare
is using lz4 wrongly. I will create a PR for this... |
|
Just documenting, @ericonr's PR has been closed since Mark Rivers is addressing this differently in areaDetector/ADEiger#91. While it still unmerged, I think we should use the last stable commit, areaDetector/ADEiger@6ca17ce. What do you think? |
|
As discussed, we need areaDetector/ADEiger@083243f for the TIFF fixes. We'll patch |
5736122 to
9c0ff9f
Compare
|
Please rebase properly onto main. |
9c0ff9f to
44dde23
Compare
ericonr
left a comment
There was a problem hiding this comment.
nit:
I prefer [1] <link-content> directly, without the colon
ea9fab9 to
81a0592
Compare
This module uses libzmq to interact with the detector data stream. Since Pilatus4 support hasn't been released yet and we are interested in using it, we are using the latest commit from the master branch instead of a tagged release. Unfortunately, this commit also adds an unwanted dependency on lz4 for the tests scripts, that are being removed in an unmerged PR [1]. Add a patch to remove this dependency. [1] areaDetector/ADEiger#91
764f630 to
6580469
Compare
Description
Add support for ADEiger module, in order to operate Pilatus4.
ZeroMQ library development package is required in the build stage of ADEiger module.
There are some unreleased features we would like to use, regarding Pilatus4 support, what makes necessary a checkout after initializing the submodule. The EDEIGER_VERSION points to the latest commit, but should point to R3-6 when the version were tagged.
Checklist
CONTRIBUTING.md;CHANGES.md, following the formatestablished by previous entries.