Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: disable bash tracing from install scripts. #45

Closed
wants to merge 1 commit into from

Conversation

henriquesimoes
Copy link
Collaborator

This level of detail pollutes the output during the build, while often not being used. In addition, it can be easily turned back on in a local setup for debugging purposes.

It should not influence any output seen by epics-in-docker users, so no entry is specified in the changelog.

This level of detail pollutes the output during the build, while often
not being used. In addition, it can be easily turned back on in a local
setup for debugging purposes.

It should not influence any output seen by epics-in-docker users, so no
entry is specified in the changelog.
@ericonr
Copy link
Member

ericonr commented Dec 20, 2023

I don't know if I agree with this. Most of the time I'm not looking at the build output anyway, and when there are issues, I don't need to run anything again, the trace output is there already. Has it bothered you in some situation?

@henriquesimoes
Copy link
Collaborator Author

That's something I've added during the development of the installation scripts back when it was a sketch for containerizing the RFFE IOC.

I think I misunderstood from one of our personal discussion that it wouldn't be needed, similarly to logic of omitting the verbose output from tar.

Has it bothered you in some situation?

Not really. We may keep them. ;)

@ericonr
Copy link
Member

ericonr commented Jan 4, 2024

I think I misunderstood from one of our personal discussion that it wouldn't be needed, similarly to logic of omitting the verbose output from tar.

I might have changed my mind on it in the meanwhile, to be quite honest 🤔

@ericonr ericonr deleted the trace-off branch January 4, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants