ci: fix building included images. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
force-pushed
the
ci-build-images
branch
from
ae1a737 to
b286823
Compare
This way, it isn't necessary to pass the JOBS variable to speed up the build when it is okay to use all machine resources (indicated by JOBS=-1).
ericonr
force-pushed
the
ci-build-images
branch
2 times, most recently
from
60f310e to
f409d7b
Compare
This is necessary for the docker buildx bake action to píck up all of them.
ericonr
force-pushed
the
ci-build-images
branch
from
544edf7 to
3eaf472
Compare
The included-images workflow was never triggered, probably due to workflow_run only really working on branches. In order to simplify things, we move the step of building those images to the same workflow as the base images. With the help of an additional step, this also allows us to build the IOC images for PRs. It was also necessary to add a conditional for building the included images, since they only use the Debian base image, not the Alpine one. In order to use the just-built base image, it was necessary to build it with "load: true". And, in order to enable the included image builds to locate the base image at all, it was necessary to set up a new builder, with "driver: docker" [1]. The "docker" driver doesn't support caching, so it's reserved for the included images. [1] docker/buildx#159 (comment)
ericonr
force-pushed
the
ci-build-images
branch
from
3eaf472 to
d3756d9
Compare
ericonr
commented
Dec 4, 2024
| with: | ||
| driver: docker | ||
| - name: Build and push included IOC images | ||
| if: ${{ matrix.image.name == 'lnls-debian-11-epics-7' }} |
There was a problem hiding this comment.
This is a new spot to change in #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included-images workflow was never triggered, probably due to workflow_run only really working on branches.
In order to simplify things, we move the step of building those images to the same workflow as the base images. With the help of an additional step, this also allows us to build (and test) the IOC images for PRs.
It was also necessary to add a conditional for building the included images, since they only use the Debian base image, not the Alpine one.