Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to the resulting image containing the build properties. #98

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add labels to the resulting image containing the build properties. #98

wants to merge 2 commits into from

Conversation

gustavosr8
Copy link
Contributor

No description provided.

@gustavosr8 gustavosr8 self-assigned this Dec 19, 2024
@gustavosr8 gustavosr8 linked an issue Dec 19, 2024 that may be closed by this pull request
Add label to the resulting image containing the build properties #24
Open
ericonr
ericonr requested changes Dec 19, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@gustavosr8 gustavosr8 force-pushed the labels branch 4 times, most recently from 610bc08 to 626c975 Compare December 20, 2024 13:03
@gustavosr8 gustavosr8 changed the title Labels Add labels to the resulting image containing the build properties. Dec 20, 2024
@gustavosr8 gustavosr8 force-pushed the labels branch 3 times, most recently from 023692b to 93ff549 Compare December 20, 2024 13:39
henriquesimoes
henriquesimoes requested changes Dec 20, 2024
View reviewed changes
.github/workflows/base-image.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
henriquesimoes
henriquesimoes requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@henriquesimoes henriquesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a label for the no-build target. BTW, is this really enough for identifying the resulting image? I think at least APP_DIRS will also be needed.

Dockerfile Outdated Show resolved Hide resolved
@gustavosr8
Copy link
Contributor Author

gustavosr8 commented Jan 6, 2025 •
edited
Loading

BTW, is this really enough for identifying the resulting image? I think at least APP_DIRS will also be needed.

Indeed. But first #59 needs to be merged to make sense. I will just convert this PR to a WIP and wait, for now.

@gustavosr8 gustavosr8 marked this pull request as draft January 6, 2025 12:47
henriquesimoes
henriquesimoes reviewed Jan 6, 2025
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
ericonr
ericonr requested changes Jan 8, 2025
View reviewed changes
.github/workflows/base-image.yml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ericonr
Copy link
Member

ericonr commented Jan 8, 2025

last commit message should be something like: "ioc: add labels with build properties to the IOC images."

henriquesimoes
henriquesimoes requested changes Jan 8, 2025
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@gustavosr8
ci: make the version match more restrictive.
b6b3989 
This prevents accidental replacements and aligns with the
`br.lnls.epics-in-docker.version` label format that will be used in the
future.
@gustavosr8
ioc: add labels with build properties to the IOC images.
4db5292
@ericonr
Copy link
Member

ericonr commented Jan 15, 2025

I have reviewed, don't have any comments now, waiting on #19 being merged and this one rebased before actually approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr Awaiting requested review from ericonr

@henriquesimoes henriquesimoes Awaiting requested review from henriquesimoes

Requested changes must be addressed to merge this pull request.

Assignees

@gustavosr8 gustavosr8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add label to the resulting image containing the build properties
3 participants
@gustavosr8 @ericonr @henriquesimoes