Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 move nf-core modules in nf-core subfolder #25

Merged
merged 14 commits into from
Dec 18, 2023
Merged

🚚 move nf-core modules in nf-core subfolder #25

merged 14 commits into from
Dec 18, 2023

Conversation

bunop
Copy link
Member

@bunop bunop commented Dec 15, 2023

PR checklist

This PR will place all external nf-core dependencies in a nf-core subfolder. This will made easier maintain custom modules

Closes #22

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@bunop bunop added bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request labels Dec 15, 2023
@bunop bunop added this to the :bookmark: public release milestone Dec 15, 2023
@bunop bunop merged commit 7ce2c52 into master Dec 18, 2023
45 of 56 checks passed
@bunop bunop deleted the issue-22 branch February 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] move nf-core modules in nf-core subfolder
1 participant